Repository navigation
Fix desktop CI: add Windows .ico and macOS .icns icons - #19
Merged
Merged
Conversation
Generate real icon.ico / icon.icns from a 1024px source mark so tauri build can produce Windows resources and macOS app icons. Co-authored-by: Damon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS and Windows desktop CI jobs failed after the
frontendDistfix because the repo only had placeholder PNGs:icons/icon.iconot found (required for the Windows resource file)Failed to create app icon: The image format could not be determinedChanges
apps/desktop/app-icon.png) and generated the full Tauri icon set viatauri icon, includingicon.icoandicon.icnstauri.conf.jsonbundle icons at the standard set (32x32,128x128,@2x,.icns,.ico)apps/desktop/README.mdDesktop builds only run on pushes to
main, so this will validate after merge.